Skip to content

file: add patch to fix stack overrun issue#411845

Closed
leojrfs wants to merge 1 commit intoNixOS:masterfrom
leojrfs:leojrfs/file-stack-overrun-patch
Closed

file: add patch to fix stack overrun issue#411845
leojrfs wants to merge 1 commit intoNixOS:masterfrom
leojrfs:leojrfs/file-stack-overrun-patch

Conversation

@leojrfs
Copy link

@leojrfs leojrfs commented May 28, 2025

This was fixed upstream but not yet released.

Issue: https://bugs.astron.com/view.php?id=638
Fix: file/file@FILE5_46-7-gb3384a1f

It should be considered to be backported to 25.05, as the issue is a regression (no issue on 24.11, file version 5.45).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label May 28, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels May 28, 2025
@nix-owners nix-owners bot requested a review from doronbehar May 28, 2025 19:29
@doronbehar
Copy link
Contributor

NOTE that a package like file which so many packages depend upon (see the automatically computed GH labels), should be changed only on the staging branch - see also:

nixpkgs/CONTRIBUTING.md

Lines 194 to 198 in b5d5cc7

### Rebasing between branches (i.e. from master to staging)
[rebase]: #rebasing-between-branches-ie-from-master-to-staging
From time to time, changes between branches must be rebased, for example, if the
number of new rebuilds they would cause is too large for the target branch.

no issue on 24.11, file version 5.45

The file 5.46 release has shown too many issues, and it's nice to add another one to the list. See also:

Just today, I got an email that upstream issue 622 was resolved. Meaning we might want to do use 5.46, with 2 patches added. However TBH, I'm a bit hesitant.

@doronbehar doronbehar closed this May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants